Astronomical Data Curation and Analysis: What has worked and what has not?